[jira] [Commented] (CXF-8257) Logger no longer logs bad requests

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view

[jira] [Commented] (CXF-8257) Logger no longer logs bad requests

jagadeesh (Jira)

    [ https://issues.apache.org/jira/browse/CXF-8257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17146207#comment-17146207 ]

Tomasz Zorawik commented on CXF-8257:

As noted in CXF-7518 (and CXF-8072) the reason why the internal LoggingInFaultInterceptor was deleted was:

“Requests that do not raise faults are logged only once (as well as their responses): _one_ REQ_IN INFO -> REQ_IN and _one_ RESP_OUT INFO -> RESP_OUT

Requests that do raise faults are logged twice (unlike their responses, logged only once): _*{color:#FF0000}two{color}*_ REQ_IN INFO -> REQ_IN and _one_ FAULT_OUT INFO -> FAULT_OUT”

This problem was fixed but it seems that the fix was not needed for _all_ requests which raise faults only for some of them. Before this fix when fault occurred at an early processing stage (like request Unmarshalling Error) such request was correctly logged once (no fix needed) as opposite to those requests where fault occurred at a later processing stage where the double logging bug was visible (and the fix was needed).

Now (after the fix – 3.3.6) when using LoggingFeature if the fault occurs at the early processing stage (like request Unmarshalling Error) the request is not logged at all. The response is still logged (FAULT_OUT INFO -> FAULT_OUT).

> Logger no longer logs bad requests
> ----------------------------------
>                 Key: CXF-8257
>                 URL: https://issues.apache.org/jira/browse/CXF-8257
>             Project: CXF
>          Issue Type: Bug
>          Components: logging
>    Affects Versions: 3.3.6
>            Reporter: Tomasz Zorawik
>            Priority: Major
> After update to CXF 3.3.6 I noticed that LoggingInInterceptor (LoggingFeature) no longer logs bad requests. This happens for instance when incorrect operation name is sent in SOAP request body. Previously in such case handleFault(Message) from LoggingInFaultInterceptor was called. It seems that this change happened between 3.3.2 and 3.3.3 where LoggingInFaultInterceptor was deleted.
> Is there a new way of logging such requests?
> This issue may be connected with CXF-7518, CXF-7562 and CXF-8072  where LoggingInFaultInterceptor was deleted and added back and forth.

This message was sent by Atlassian Jira