[jira] [Commented] (CXF-7923) String.split via fastpath instead of precompiled Pattern

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (CXF-7923) String.split via fastpath instead of precompiled Pattern

JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/CXF-7923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16712808#comment-16712808 ]

ASF GitHub Bot commented on CXF-7923:
-------------------------------------

amarkevich commented on a change in pull request #481: CXF-7923 String.split via fastpath instead of precompiled Pattern
URL: https://github.com/apache/cxf/pull/481#discussion_r239790887
 
 

 ##########
 File path: core/src/main/java/org/apache/cxf/common/util/PackageUtils.java
 ##########
 @@ -57,7 +58,7 @@ public static String getSharedPackageName(List<Class<?>> classes) {
         List<String> currentParts = new ArrayList<>();
         for (Class<?> cls : classes) {
             if (!Proxy.isProxyClass(cls)) {
-                lParts.add(StringUtils.getParts(getPackageName(cls), "\\."));
+                lParts.add(Arrays.asList(getPackageName(cls).split("\\.")));
 
 Review comment:
   PackageUtils: 'A package name must not contain two consecutive dots' (Eclipse validation)
   AbstractHTTPDestination: according to [1] only single space character accepted
   1. https://tools.ietf.org/html/rfc1945#section-11.1

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


> String.split via fastpath instead of precompiled Pattern
> --------------------------------------------------------
>
>                 Key: CXF-7923
>                 URL: https://issues.apache.org/jira/browse/CXF-7923
>             Project: CXF
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 3.2.7
>            Reporter: Alexey Markevich
>            Assignee: Alexey Markevich
>            Priority: Major
>             Fix For: 3.3.0
>
>
> Initial PR https://github.com/apache/cxf/pull/479



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)