[jira] [Commented] (CXF-7642) Split rxjava and rxjava2 modules

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (CXF-7642) Split rxjava and rxjava2 modules

JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/CXF-7642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16360121#comment-16360121 ]

ASF GitHub Bot commented on CXF-7642:
-------------------------------------

johnament commented on a change in pull request #381: [CXF-7642] Introduce separate modules for RxJava & RxJava2
URL: https://github.com/apache/cxf/pull/381#discussion_r167449364
 
 

 ##########
 File path: rt/rs/extensions/reactor/src/main/java/org/apache/cxf/jaxrs/reactor/server/ReactorCustomizer.java
 ##########
 @@ -0,0 +1,39 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.cxf.jaxrs.reactor.server;
+
+import java.util.Collections;
+
+import org.apache.cxf.jaxrs.JAXRSServerFactoryBean;
+import org.apache.cxf.jaxrs.ext.JAXRSServerFactoryCustomizationExtension;
+import org.apache.cxf.jaxrs.provider.StreamingResponseProvider;
+
+public class ReactorCustomizer implements JAXRSServerFactoryCustomizationExtension {
+    @Override
+    public void customize(JAXRSServerFactoryBean bean) {
+        Boolean useStreamingSubscriber = (Boolean)bean.getProperties(true)
+                .getOrDefault("useStreamingSubscriber", false);
+        ReactorInvoker invoker = new ReactorInvoker();
+        invoker.setUseStreamingSubscriberIfPossible(useStreamingSubscriber);
+        bean.setInvoker(invoker);
+        StreamingResponseProvider<Object> streamProvider = new StreamingResponseProvider<>();
+        streamProvider.setProduceMediaTypes(Collections.singletonList("application/json"));
 
 Review comment:
   Agreed.  Actually, after I pulled this out I decided I really need a base class for these extensions.    So I'm going to take care of that before merging.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


> Split rxjava and rxjava2 modules
> --------------------------------
>
>                 Key: CXF-7642
>                 URL: https://issues.apache.org/jira/browse/CXF-7642
>             Project: CXF
>          Issue Type: Improvement
>          Components: JAX-RS
>    Affects Versions: 3.2.2
>            Reporter: John D. Ament
>            Priority: Major
>
> Split the two modules (rxjava, rxjava2) to fix the dependency hierarchy.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)