[jira] [Comment Edited] (CXF-8169) CXF opentracing - Span#finish is never called in case of client timeouts

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Comment Edited] (CXF-8169) CXF opentracing - Span#finish is never called in case of client timeouts

Andriy Redko (Jira)

    [ https://issues.apache.org/jira/browse/CXF-8169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16985685#comment-16985685 ]

Andriy Redko edited comment on CXF-8169 at 12/1/19 9:47 PM:
------------------------------------------------------------

[~baiglin] thank you for issue, test case and possible fix. The fix needs a bit more work but you were on the right track nonetheless, thanks a lot, it was really helpful. Best Regards, Andriy Redko


was (Author: reta):
Thank you for the [~baiglin]  issue, test case and possible fix. The fix needs a bit more work but you were on the right track nonetheless, thanks a lot, it was really helpful.

> CXF opentracing - Span#finish is never called in case of client timeouts
> ------------------------------------------------------------------------
>
>                 Key: CXF-8169
>                 URL: https://issues.apache.org/jira/browse/CXF-8169
>             Project: CXF
>          Issue Type: Bug
>          Components: Tracing
>    Affects Versions: 3.2.11, 3.3.4, 3.4.0
>            Reporter: Baptiste AIGLIN
>            Assignee: Andriy Redko
>            Priority: Major
>             Fix For: 3.4.0, 3.3.5, 3.2.12
>
>         Attachments: cxf-reproducer.tar.gz
>
>
> While using the CXF opentracing feature with any CXF client, we see that in case of connectionTimeout or receiveTimeout the span#finish is never called by the OpenTracing client interceptors. We can clearly see that inside the OpenTracingClientStopInterceptor from the OpenTracingClientFeature there is no handleFault() method defined to handle such case.
> I wrote the test allowing to reproduce this behavior using a JAX-RS client and a really simplistic fix on the CustomOpenTracingClientFeature where the current OpenTracingClientStartInterceptor is overriden in order to add such handleFault method and using the OpenTracingClientStopInterceptor#handleMethod in order to trigger the stop.
> Thanks in advance for your feedback.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)