[GitHub] johnament commented on a change in pull request #369: [CXF-7610] - Adding SPI to handle customizations to the server bean.

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] johnament commented on a change in pull request #369: [CXF-7610] - Adding SPI to handle customizations to the server bean.

GitBox
johnament commented on a change in pull request #369: [CXF-7610] - Adding SPI to handle customizations to the server bean.
URL: https://github.com/apache/cxf/pull/369#discussion_r166179129
 
 

 ##########
 File path: rt/rs/sse/src/main/resources/META-INF/beans.xml
 ##########
 @@ -2,5 +2,5 @@
 <beans xmlns="http://java.sun.com/xml/ns/javaee"
  xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
  xsi:schemaLocation="http://java.sun.com/xml/ns/javaee http://xmlns.jcp.org/xml/ns/javaee/beans_1_1.xsd"
- bean-discovery-mode="all">
 
 Review comment:
   I ended up going the route of adding the feature's behavior into the extension.  Thoughts?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services