[GitHub] [cxf] shark300 commented on a change in pull request #642: [CXF-8213] Add Micrometer metric support for JAX-WS

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view

[GitHub] [cxf] shark300 commented on a change in pull request #642: [CXF-8213] Add Micrometer metric support for JAX-WS


shark300 commented on a change in pull request #642:
URL: https://github.com/apache/cxf/pull/642#discussion_r505618695

File path: rt/features/metrics/src/main/java/org/apache/cxf/metrics/micrometer/provider/jaxws/JaxwsTagsProvider.java
@@ -0,0 +1,62 @@
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.cxf.metrics.micrometer.provider.jaxws;
+import org.apache.cxf.message.Exchange;
+import org.apache.cxf.message.Message;
+import org.apache.cxf.metrics.micrometer.provider.ExceptionClassProvider;
+import org.apache.cxf.metrics.micrometer.provider.TagsProvider;
+import io.micrometer.core.instrument.Tag;
+import io.micrometer.core.instrument.Tags;
+import static java.util.Optional.ofNullable;
+public class JaxwsTagsProvider implements TagsProvider {

Review comment:
       I would like to left open the possibility for JaxrsTagsProvider.

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]