[GitHub] [cxf] reta opened a new pull request #723: [WIP] Update to Spring Boot 2.4.0 / Spring Framework 5.3.1 / Spring Security 5.4.1 / Reactor 3.4.0 / Micrometer 1.6.1

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [cxf] reta opened a new pull request #723: [WIP] Update to Spring Boot 2.4.0 / Spring Framework 5.3.1 / Spring Security 5.4.1 / Reactor 3.4.0 / Micrometer 1.6.1

GitBox

reta opened a new pull request #723:
URL: https://github.com/apache/cxf/pull/723


   Update to Spring Boot 2.4.0
   Update to Spring Framework 5.3.1
   Update to Spring Security 5.4.1
   Update to Project Reactor 3.4.0
   Update to Micrometer 1.6.1


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [cxf] reta commented on pull request #723: Update to Spring Boot 2.4.0 / Spring Framework 5.3.1 / Spring Security 5.4.1 / Reactor 3.4.0 / Micrometer 1.6.1

GitBox

reta commented on pull request #723:
URL: https://github.com/apache/cxf/pull/723#issuecomment-727680595


   @deki @coheigea @amarkevich the update looks good now, one thing I intended to incorporate is switch to Maven Surefire 3.0.0-M5 (so we could run JUnit 4 & JUnit 5 test cases side by side) but I run into an issue with tooling tests `org.apache.cxf.tools.common.ProcessorTestBase::getClassPath()` which seems to be relying on some Surefire intrinsic details, probably better to tackle as separate effort. If no objections, I would like to merge it into master.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [cxf] coheigea commented on a change in pull request #723: Update to Spring Boot 2.4.0 / Spring Framework 5.3.1 / Spring Security 5.4.1 / Reactor 3.4.0 / Micrometer 1.6.1

GitBox
In reply to this post by GitBox

coheigea commented on a change in pull request #723:
URL: https://github.com/apache/cxf/pull/723#discussion_r523924472



##########
File path: systests/transports/pom.xml
##########
@@ -331,6 +331,11 @@
             <version>${cxf.bcprov.version}</version>
             <scope>test</scope>
         </dependency>
+        <dependency>
+            <groupId>org.junit.vintage</groupId>
+            <artifactId>junit-vintage-engine</artifactId>
+            <scope>test</scope>
+        </dependency>

Review comment:
       Why the need for the vintage-engine dependency here?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [cxf] reta commented on a change in pull request #723: Update to Spring Boot 2.4.0 / Spring Framework 5.3.1 / Spring Security 5.4.1 / Reactor 3.4.0 / Micrometer 1.6.1

GitBox
In reply to this post by GitBox

reta commented on a change in pull request #723:
URL: https://github.com/apache/cxf/pull/723#discussion_r524175866



##########
File path: systests/transports/pom.xml
##########
@@ -331,6 +331,11 @@
             <version>${cxf.bcprov.version}</version>
             <scope>test</scope>
         </dependency>
+        <dependency>
+            <groupId>org.junit.vintage</groupId>
+            <artifactId>junit-vintage-engine</artifactId>
+            <scope>test</scope>
+        </dependency>

Review comment:
       The `transports` uses a mix of JUnit 4 and JUnit 5 tests, we need the Vintage engine to run JUnit 4 tests using JUnit 5 platform, otherwise they are going to be skipped.  




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [cxf] reta merged pull request #723: Update to Spring Boot 2.4.0 / Spring Framework 5.3.1 / Spring Security 5.4.1 / Reactor 3.4.0 / Micrometer 1.6.1

GitBox
In reply to this post by GitBox

reta merged pull request #723:
URL: https://github.com/apache/cxf/pull/723


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]