[GitHub] [cxf] reta opened a new pull request #699: CXF-8337: wsdl2java generates exceptions fields which do not follow naming convention

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [cxf] reta opened a new pull request #699: CXF-8337: wsdl2java generates exceptions fields which do not follow naming convention

GitBox

reta opened a new pull request #699:
URL: https://github.com/apache/cxf/pull/699


   wsdl2java generates wrapper exception class for fault bean. The generated exception has method getFaultInfo(). This method name is correct according to JAX-WS specification. However this method returns fault bean stored in a field called "name of fault bean". The name of the field and getter do not follow the naming convention.
   
   In general, it does not cause issue unless such fault beans becomes serialization / deserialization targets (the absence of the setter method `setFaultInfo`  makes the matter difficult).
   
   @coheigea @dkulp may I ask you please to take a look? thanks!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [cxf] reta commented on pull request #699: CXF-8337: wsdl2java generates exceptions fields which do not follow naming convention

GitBox

reta commented on pull request #699:
URL: https://github.com/apache/cxf/pull/699#issuecomment-702721737


   @coheigea if you don't mind to take a look, pretty trivial change :) thanks!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [cxf] coheigea commented on pull request #699: CXF-8337: wsdl2java generates exceptions fields which do not follow naming convention

GitBox
In reply to this post by GitBox

coheigea commented on pull request #699:
URL: https://github.com/apache/cxf/pull/699#issuecomment-702730919


   @reta No objections from me, but the build is currently broken - so I'd prefer to make sure all tests are green before merging.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [cxf] reta merged pull request #699: CXF-8337: wsdl2java generates exceptions fields which do not follow naming convention

GitBox
In reply to this post by GitBox

reta merged pull request #699:
URL: https://github.com/apache/cxf/pull/699


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [cxf] reta merged pull request #699: CXF-8337: wsdl2java generates exceptions fields which do not follow naming convention

GitBox
In reply to this post by GitBox

reta merged pull request #699:
URL: https://github.com/apache/cxf/pull/699


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]