[GitHub] [cxf] reta commented on a change in pull request #642: [CXF-8213] Add Micrometer metric support for JAX-WS

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [cxf] reta commented on a change in pull request #642: [CXF-8213] Add Micrometer metric support for JAX-WS

GitBox

reta commented on a change in pull request #642:
URL: https://github.com/apache/cxf/pull/642#discussion_r506958861



##########
File path: rt/features/metrics/pom.xml
##########
@@ -34,14 +34,33 @@
             <optional>true</optional>
         </dependency>
 
+        <dependency>
+            <groupId>io.micrometer</groupId>
+            <artifactId>micrometer-core</artifactId>
+            <optional>true</optional>
+        </dependency>
+
+        <dependency>
+            <groupId>com.google.guava</groupId>

Review comment:
       Please remove this dependency, not need really (see please the suggested alternative)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]