[GitHub] [cxf-fediz] amergey opened a new pull request #53: Support SAML encrypted tokens

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [cxf-fediz] amergey opened a new pull request #53: Support SAML encrypted tokens

GitBox

amergey opened a new pull request #53:
URL: https://github.com/apache/cxf-fediz/pull/53


   While testing fediz tomcat plugin with Sign&go IDP, I was facing issues as SAML Encrypted token are not supported.
   The first commit is adding support for Encrypted assertion.
   
   Then I was still facing issues, as encrypted assertion remove the necessity to sign the assertion.
   The second commit proposes a way to disable assertions signature validation
   
   The last issue I noticed was about an attribute statement with a space inside the name. The fix for that is the 3rd commit (I am not 100 % sure having space in attribute name is valid so I separate the commit)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [cxf-fediz] coheigea commented on pull request #53: Support SAML encrypted tokens

GitBox

coheigea commented on pull request #53:
URL: https://github.com/apache/cxf-fediz/pull/53#issuecomment-643151621


   @amergey Thanks for the PR. Could you separate all three issues into separate PRs please to make it easier to review them?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [cxf-fediz] amergey commented on pull request #53: Support SAML encrypted tokens

GitBox
In reply to this post by GitBox

amergey commented on pull request #53:
URL: https://github.com/apache/cxf-fediz/pull/53#issuecomment-643168253


   Encrypted assertion part is in https://github.com/apache/cxf-fediz/pull/55
   Usigned assertion is in https://github.com/apache/cxf-fediz/pull/54
   Attribute Name parsing fix is in https://github.com/apache/cxf-fediz/pull/56


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [cxf-fediz] coheigea closed pull request #53: Support SAML encrypted tokens

GitBox
In reply to this post by GitBox

coheigea closed pull request #53:
URL: https://github.com/apache/cxf-fediz/pull/53


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [cxf-fediz] coheigea commented on pull request #53: Support SAML encrypted tokens

GitBox
In reply to this post by GitBox

coheigea commented on pull request #53:
URL: https://github.com/apache/cxf-fediz/pull/53#issuecomment-643175658


   Thanks! Please close this PR then if no longer needed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]