[GitHub] [cxf] coheigea commented on a change in pull request #585: cxf-rt-rs-client: set Accept header to wildcard for void response

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [cxf] coheigea commented on a change in pull request #585: cxf-rt-rs-client: set Accept header to wildcard for void response

GitBox
coheigea commented on a change in pull request #585: cxf-rt-rs-client: set Accept header to wildcard for void response
URL: https://github.com/apache/cxf/pull/585#discussion_r332452766
 
 

 ##########
 File path: rt/rs/client/src/main/java/org/apache/cxf/jaxrs/client/ClientProxyImpl.java
 ##########
 @@ -477,16 +477,18 @@ protected void checkResponse(Method m, Response r, Message inMessage) throws Thr
         List<MediaType> accepts = getAccept(headers);
         if (accepts == null) {
             List<MediaType> produceTypes = ori.getProduceTypes();
 
 Review comment:
   LGTM but here "produceTypes" could be in the else statement instead.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services