[GitHub] [cxf] amarkevich opened a new pull request #685: Update to activemq 5.16.0

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [cxf] amarkevich opened a new pull request #685: Update to activemq 5.16.0

GitBox

amarkevich opened a new pull request #685:
URL: https://github.com/apache/cxf/pull/685


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [cxf] coheigea commented on pull request #685: Update to activemq 5.16.0

GitBox

coheigea commented on pull request #685:
URL: https://github.com/apache/cxf/pull/685#issuecomment-663378956


   There is a problem with OSGi - https://issues.apache.org/jira/browse/AMQ-8009


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [cxf] coheigea removed a comment on pull request #685: Update to activemq 5.16.0

GitBox
In reply to this post by GitBox

coheigea removed a comment on pull request #685:
URL: https://github.com/apache/cxf/pull/685#issuecomment-663378956


   There is a problem with OSGi - https://issues.apache.org/jira/browse/AMQ-8009


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [cxf] coheigea commented on pull request #685: Update to activemq 5.16.0

GitBox
In reply to this post by GitBox

coheigea commented on pull request #685:
URL: https://github.com/apache/cxf/pull/685#issuecomment-663380207


   I've submitted a PR to AMQ to fix the issue with Spring - https://issues.apache.org/jira/browse/AMQ-8009


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [cxf] amarkevich commented on a change in pull request #685: Update to activemq 5.16.0

GitBox
In reply to this post by GitBox

amarkevich commented on a change in pull request #685:
URL: https://github.com/apache/cxf/pull/685#discussion_r459890905



##########
File path: osgi/itests/src/test/java/org/apache/cxf/osgi/itests/soap/JmsServiceTest.java
##########
@@ -78,8 +78,10 @@ private static ActiveMQConnectionFactory createConnectionFactory() {
         return OptionUtils.combine(
             cxfBaseConfig(),
             features(cxfUrl, "cxf-jaxws", "cxf-transports-jms"),
+            features(maven().groupId("org.apache.karaf.features").artifactId("spring-legacy").versionAsInProject()

Review comment:
       spring-legacy feature descriptor added to avoid activemq-client feature installation error




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [cxf] coheigea commented on a change in pull request #685: Update to activemq 5.16.0

GitBox
In reply to this post by GitBox

coheigea commented on a change in pull request #685:
URL: https://github.com/apache/cxf/pull/685#discussion_r459958571



##########
File path: osgi/itests/src/test/java/org/apache/cxf/osgi/itests/soap/JmsServiceTest.java
##########
@@ -78,8 +78,10 @@ private static ActiveMQConnectionFactory createConnectionFactory() {
         return OptionUtils.combine(
             cxfBaseConfig(),
             features(cxfUrl, "cxf-jaxws", "cxf-transports-jms"),
+            features(maven().groupId("org.apache.karaf.features").artifactId("spring-legacy").versionAsInProject()

Review comment:
       Could you add in a link to the AMQ issue here so that we know to remove it when 5.16.1 is released? Same for the spring-legacy dependency in the pom.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [cxf] amarkevich commented on a change in pull request #685: Update to activemq 5.16.0

GitBox
In reply to this post by GitBox

amarkevich commented on a change in pull request #685:
URL: https://github.com/apache/cxf/pull/685#discussion_r460009998



##########
File path: osgi/itests/src/test/java/org/apache/cxf/osgi/itests/soap/JmsServiceTest.java
##########
@@ -78,8 +78,10 @@ private static ActiveMQConnectionFactory createConnectionFactory() {
         return OptionUtils.combine(
             cxfBaseConfig(),
             features(cxfUrl, "cxf-jaxws", "cxf-transports-jms"),
+            features(maven().groupId("org.apache.karaf.features").artifactId("spring-legacy").versionAsInProject()

Review comment:
       added




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [cxf] amarkevich merged pull request #685: Update to activemq 5.16.0

GitBox
In reply to this post by GitBox

amarkevich merged pull request #685:
URL: https://github.com/apache/cxf/pull/685


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]