[GitHub] [cxf] amarkevich opened a new pull request #646: CXF-8229 OAuth 2.0 Dynamic Client Registration: Client Update Request

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [cxf] amarkevich opened a new pull request #646: CXF-8229 OAuth 2.0 Dynamic Client Registration: Client Update Request

GitBox
amarkevich opened a new pull request #646: CXF-8229 OAuth 2.0 Dynamic Client Registration: Client Update Request
URL: https://github.com/apache/cxf/pull/646
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [cxf] coheigea commented on a change in pull request #646: CXF-8229 OAuth 2.0 Dynamic Client Registration: Client Update Request

GitBox
coheigea commented on a change in pull request #646: CXF-8229 OAuth 2.0 Dynamic Client Registration: Client Update Request
URL: https://github.com/apache/cxf/pull/646#discussion_r388334951
 
 

 ##########
 File path: systests/rs-security/src/test/java/org/apache/cxf/systest/jaxrs/security/oidc/OIDCDynamicRegistrationTest.java
 ##########
 @@ -237,17 +212,63 @@ public void testRegisterClientInitialAccessTokenCodeGrantTls() throws Exception
         assertEquals(200, wc.delete().getStatus());
     }
 
+    @org.junit.Test
+    public void testUpdateClient() throws Exception {
 
 Review comment:
   Could you add a test to make sure it's not possible to "put" (or delete actually, GET is already covered) without specifying an access token?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [cxf] coheigea commented on a change in pull request #646: CXF-8229 OAuth 2.0 Dynamic Client Registration: Client Update Request

GitBox
In reply to this post by GitBox
coheigea commented on a change in pull request #646: CXF-8229 OAuth 2.0 Dynamic Client Registration: Client Update Request
URL: https://github.com/apache/cxf/pull/646#discussion_r388335158
 
 

 ##########
 File path: rt/rs/security/oauth-parent/oauth2/src/main/java/org/apache/cxf/rs/security/oauth2/utils/OAuthUtils.java
 ##########
 @@ -429,6 +429,6 @@ public static SignatureAlgorithm getClientSecretSignatureAlgorithm(Properties si
     }
 
     public static String convertListOfScopesToString(List<String> registeredScopes) {
-        return String.join(", ", registeredScopes);
+        return String.join(" ", registeredScopes);
 
 Review comment:
   What's the reason behind this change?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [cxf] amarkevich commented on a change in pull request #646: CXF-8229 OAuth 2.0 Dynamic Client Registration: Client Update Request

GitBox
In reply to this post by GitBox
amarkevich commented on a change in pull request #646: CXF-8229 OAuth 2.0 Dynamic Client Registration: Client Update Request
URL: https://github.com/apache/cxf/pull/646#discussion_r388473869
 
 

 ##########
 File path: systests/rs-security/src/test/java/org/apache/cxf/systest/jaxrs/security/oidc/OIDCDynamicRegistrationTest.java
 ##########
 @@ -237,17 +212,63 @@ public void testRegisterClientInitialAccessTokenCodeGrantTls() throws Exception
         assertEquals(200, wc.delete().getStatus());
     }
 
+    @org.junit.Test
+    public void testUpdateClient() throws Exception {
 
 Review comment:
   ok

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [cxf] amarkevich commented on a change in pull request #646: CXF-8229 OAuth 2.0 Dynamic Client Registration: Client Update Request

GitBox
In reply to this post by GitBox
amarkevich commented on a change in pull request #646: CXF-8229 OAuth 2.0 Dynamic Client Registration: Client Update Request
URL: https://github.com/apache/cxf/pull/646#discussion_r388476260
 
 

 ##########
 File path: rt/rs/security/oauth-parent/oauth2/src/main/java/org/apache/cxf/rs/security/oauth2/utils/OAuthUtils.java
 ##########
 @@ -429,6 +429,6 @@ public static SignatureAlgorithm getClientSecretSignatureAlgorithm(Properties si
     }
 
     public static String convertListOfScopesToString(List<String> registeredScopes) {
-        return String.join(", ", registeredScopes);
+        return String.join(" ", registeredScopes);
 
 Review comment:
   https://tools.ietf.org/html/rfc7591#section-4.1.2
   
   >    o  Client Metadata Name: "scope"
   >    o  Client Metadata Description: Space-separated list of OAuth 2.0
   >       scope values

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [cxf] amarkevich merged pull request #646: CXF-8229 OAuth 2.0 Dynamic Client Registration: Client Update Request

GitBox
In reply to this post by GitBox
amarkevich merged pull request #646: CXF-8229 OAuth 2.0 Dynamic Client Registration: Client Update Request
URL: https://github.com/apache/cxf/pull/646
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services