[GitHub] [cxf] NaridaL opened a new pull request #624: getBytes uses the platform charset by default.

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [cxf] NaridaL opened a new pull request #624: getBytes uses the platform charset by default.

GitBox
NaridaL opened a new pull request #624: getBytes uses the platform charset by default.
URL: https://github.com/apache/cxf/pull/624
 
 
   As far as I can see, the only place where the schemas are loaded into the cache is loadSchemasIntoCache, where they are extracted from an XML Document. As such, they won't have an associated encoding. The XMLSource defaults to UTF-8, so this blows up if you have special characters and, for example, windows-1252 as the platform charset.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [cxf] coheigea commented on a change in pull request #624: getBytes uses the platform charset by default.

GitBox
coheigea commented on a change in pull request #624: getBytes uses the platform charset by default.
URL: https://github.com/apache/cxf/pull/624#discussion_r366278136
 
 

 ##########
 File path: rt/rs/description/src/main/java/org/apache/cxf/jaxrs/model/wadl/WadlGenerator.java
 ##########
 @@ -32,6 +32,7 @@
 import java.lang.reflect.TypeVariable;
 import java.net.URI;
 import java.net.URL;
+import java.nio.charset.StandardCharsets;
 import java.util.ArrayList;
 
 Review comment:
   Please remove the ByteArrayOutputStream import which is no longer required, to fix a checkstyle problem.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [cxf] NaridaL commented on a change in pull request #624: getBytes uses the platform charset by default.

GitBox
In reply to this post by GitBox
NaridaL commented on a change in pull request #624: getBytes uses the platform charset by default.
URL: https://github.com/apache/cxf/pull/624#discussion_r366300219
 
 

 ##########
 File path: rt/rs/description/src/main/java/org/apache/cxf/jaxrs/model/wadl/WadlGenerator.java
 ##########
 @@ -32,6 +32,7 @@
 import java.lang.reflect.TypeVariable;
 import java.net.URI;
 import java.net.URL;
+import java.nio.charset.StandardCharsets;
 import java.util.ArrayList;
 
 Review comment:
   Done.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [cxf] coheigea merged pull request #624: getBytes uses the platform charset by default.

GitBox
In reply to this post by GitBox
coheigea merged pull request #624: getBytes uses the platform charset by default.
URL: https://github.com/apache/cxf/pull/624
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services