Created: (CXF-2016) Add wildcard type signature to InterceptorProvider and implementations

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

Created: (CXF-2016) Add wildcard type signature to InterceptorProvider and implementations

JIRA jira@apache.org
Add wildcard type signature to InterceptorProvider and implementations
----------------------------------------------------------------------

                 Key: CXF-2016
                 URL: https://issues.apache.org/jira/browse/CXF-2016
             Project: CXF
          Issue Type: Improvement
          Components: Core
    Affects Versions: 2.1.2
            Reporter: Kenny MacLeod
            Priority: Trivial


org.apache.cxf.interceptor.InterceptorProvider and its implementation classes refer to the raw Interceptor type. The lack of a generic type signature here means that application code which talks to this API has to have warning suppressions liberally sprinkled around.

At the very least, Interceptor<?> should be used here, if not something more specific.  

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (CXF-2016) Add wildcard type signature to InterceptorProvider and implementations

JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/CXF-2016?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Kulp updated CXF-2016:
-----------------------------

    Attachment: cxf-2016.txt


This is something I'd also like to do, but it's not "source compatible" and thus something that requires some attention from a "migration" standpoint.  

I've attached a patch that changes this for the current trunk.   It would be great if you took a look to see if that is "acceptable".   Then we can figure out if it's something that can/should go into 2.2 or not.  

As mentioned, while it is binary compatible, it's not source compatible as source that compiled with the old apis may no longer compile with this change.   Thus, it would definitely need to be mentioned in any migration guide.

> Add wildcard type signature to InterceptorProvider and implementations
> ----------------------------------------------------------------------
>
>                 Key: CXF-2016
>                 URL: https://issues.apache.org/jira/browse/CXF-2016
>             Project: CXF
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 2.1.2
>            Reporter: Kenny MacLeod
>            Priority: Trivial
>         Attachments: cxf-2016.txt
>
>
> org.apache.cxf.interceptor.InterceptorProvider and its implementation classes refer to the raw Interceptor type. The lack of a generic type signature here means that application code which talks to this API has to have warning suppressions liberally sprinkled around.
> At the very least, Interceptor<?> should be used here, if not something more specific.  

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (CXF-2016) Add wildcard type signature to InterceptorProvider and implementations

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/CXF-2016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12772320#action_12772320 ]

Benson Margulies commented on CXF-2016:
---------------------------------------

Dan, let's do this for 2.3.

> Add wildcard type signature to InterceptorProvider and implementations
> ----------------------------------------------------------------------
>
>                 Key: CXF-2016
>                 URL: https://issues.apache.org/jira/browse/CXF-2016
>             Project: CXF
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 2.1.2
>            Reporter: Kenny MacLeod
>            Priority: Trivial
>         Attachments: cxf-2016.txt
>
>
> org.apache.cxf.interceptor.InterceptorProvider and its implementation classes refer to the raw Interceptor type. The lack of a generic type signature here means that application code which talks to this API has to have warning suppressions liberally sprinkled around.
> At the very least, Interceptor<?> should be used here, if not something more specific.  

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (CXF-2016) Add wildcard type signature to InterceptorProvider and implementations

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/CXF-2016?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Kulp updated CXF-2016:
-----------------------------

    Fix Version/s: 2.3

> Add wildcard type signature to InterceptorProvider and implementations
> ----------------------------------------------------------------------
>
>                 Key: CXF-2016
>                 URL: https://issues.apache.org/jira/browse/CXF-2016
>             Project: CXF
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 2.1.2
>            Reporter: Kenny MacLeod
>            Priority: Trivial
>             Fix For: 2.3
>
>         Attachments: cxf-2016.txt
>
>
> org.apache.cxf.interceptor.InterceptorProvider and its implementation classes refer to the raw Interceptor type. The lack of a generic type signature here means that application code which talks to this API has to have warning suppressions liberally sprinkled around.
> At the very least, Interceptor<?> should be used here, if not something more specific.  

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Resolved: (CXF-2016) Add wildcard type signature to InterceptorProvider and implementations

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/CXF-2016?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Kulp resolved CXF-2016.
------------------------------

    Resolution: Fixed
      Assignee: Daniel Kulp

> Add wildcard type signature to InterceptorProvider and implementations
> ----------------------------------------------------------------------
>
>                 Key: CXF-2016
>                 URL: https://issues.apache.org/jira/browse/CXF-2016
>             Project: CXF
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 2.1.2
>            Reporter: Kenny MacLeod
>            Assignee: Daniel Kulp
>            Priority: Trivial
>             Fix For: 2.3
>
>         Attachments: cxf-2016.txt
>
>
> org.apache.cxf.interceptor.InterceptorProvider and its implementation classes refer to the raw Interceptor type. The lack of a generic type signature here means that application code which talks to this API has to have warning suppressions liberally sprinkled around.
> At the very least, Interceptor<?> should be used here, if not something more specific.  

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.